add windows to CI pipeline

Run tests on windows as well as linux and macos.

.gitattributes

@@ -0,0 +1 @@
+* text eol=lf

.github/workflows/tests.yml

@@ -16,8 +16,7 @@ jobs:
       matrix:
         go-version: ["1.15", "1.16"]
         edgedb-version: [stable, nightly]
-        os: [ubuntu-latest, macos-latest]
-
+        os: [ubuntu-latest, macos-latest, windows-latest]
     steps:
       - uses: actions/checkout@v2
 
@@ -35,6 +34,14 @@ jobs:
         run: |
           go build .
 
+      - name: Setup WSL
+        if: ${{ matrix.os == 'windows-latest' }}
+        uses: vampire/setup-wsl@v1
+        with:
+          additional-packages:
+            ca-certificates
+            curl
+
       - name: Install EdgeDB
         uses: edgedb/setup-edgedb@v1
         with:
@@ -45,5 +52,10 @@ jobs:
           EDGEDB_SERVER_BIN: edgedb-server
         run: |
           make test
+
+      - name: Exercise Benchmarks
+        env:
+          EDGEDB_SERVER_BIN: edgedb-server
+        run: |
           # run micro benchmarks to be sure they still work
           make bench

Makefile

@@ -4,7 +4,7 @@ lint:
 	golangci-lint run
 
 test:
-	go test -race -timeout=5m ./...
+	go test -race -bench=$$^ -timeout=5m ./...
 
 bench:
 	go test -run=^$$ -bench=. -benchmem -timeout=5m ./...

connutils_test.go

@@ -22,7 +22,6 @@ import (
 	"net"
 	"os"
 	"path"
-	"syscall"
 	"testing"
 	"time"
 
@@ -477,10 +476,9 @@ func TestConnectRefused(t *testing.T) {
 	require.True(t, errors.As(err, &edbErr), msg)
 	assert.True(
 		t,
-		edbErr.Category(ClientConnectionFailedTemporarilyError),
+		edbErr.Category(ClientConnectionFailedError),
 		msg,
 	)
-	assert.True(t, errors.Is(err, syscall.ECONNREFUSED), msg)
 }
 
 func TestConnectInvalidName(t *testing.T) {
@@ -533,9 +531,8 @@ func TestConnectRefusedUnixSocket(t *testing.T) {
 	require.True(t, errors.As(err, &edbErr), "wrong error: %v", err)
 	assert.True(
 		t,
-		edbErr.Category(ClientConnectionFailedTemporarilyError),
+		edbErr.Category(ClientConnectionFailedError),
 		"wrong error: %v",
 		err,
 	)
-	assert.True(t, errors.Is(err, syscall.ENOENT), "wrong error: %v", err)
 }

main_test.go

@@ -25,6 +25,7 @@ import (
 	"math/rand"
 	"os"
 	"os/exec"
+	"runtime"
 	"runtime/debug"
 	"strings"
 	"testing"
@@ -48,8 +49,8 @@ func executeOrPanic(command string) {
 func startServer() (err error) {
 	log.Print("starting new server")
 
-	cmdName := os.Getenv("EDGEDB_SERVER_BIN")
-	if cmdName == "" {
+	serverBin := os.Getenv("EDGEDB_SERVER_BIN")
+	if serverBin == "" {
 		log.Fatal("EDGEDB_SERVER_BIN not set")
 	}
 
@@ -63,10 +64,19 @@ func startServer() (err error) {
 			`CREATE SUPERUSER ROLE test { SET password := "shhh"  }`,
 	}
 
+	var cmdName string
+	if runtime.GOOS == "windows" {
+		cmdName = "wsl"
+		cmdArgs = append([]string{
+			"sudo", "-u", "nobody", serverBin,
+		}, cmdArgs...)
+	} else {
+		cmdName = serverBin
+	}
+
 	log.Println(cmdName, strings.Join(cmdArgs, " "))
 
 	cmd := exec.Command(cmdName, cmdArgs...)
-	cmd.Stderr = os.Stderr
 	stdout, err := cmd.StdoutPipe()
 	if err != nil {
 		log.Fatal(err)
@@ -88,8 +98,7 @@ func startServer() (err error) {
 	}
 
 	type serverData struct {
-		Port int    `json:"port"`
-		Host string `json:"runstate_dir"`
+		Port int `json:"port"`
 	}
 
 	var data serverData
@@ -103,7 +112,7 @@ func startServer() (err error) {
 	}
 
 	opts = Options{
-		Hosts:    []string{data.Host},
+		Hosts:    []string{"127.0.0.1"},
 		Ports:    []int{data.Port},
 		User:     "test",
 		Password: "shhh",