This repository was archived by the owner on Feb 13, 2023. It is now read-only.
Issue #1370: Add VirtualBox version requirement check #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still torn on this. There are enough reports of weird things happening for people stuck on 5.0.x—but then this might introduce new reports of "I'm not using VirtualBox, why is Drupal VM complaining about it!" and other things like that. It's kind of six of one, half dozen the other... and closing this out means less code to maintain, so that's one benefit of not including it. |
|
Especially if we consider adding Vagrant-based Docker support, and people want to play around with that, but still have an older release of VirtualBox installed for some reason. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #1370, this is not 100% reliable as it enforces the version requirements as long as VirtualBox is available, regardless if the provider is used or not.
As there's no way to determine the current provider in a
Vagrantfile, I don't think we can improve this. Feel free to close if you think the false positives outweigh the benefit.