Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GI and NDN to Our Work #408

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add GI and NDN to Our Work #408

wants to merge 5 commits into from

Conversation

honor-gfsc
Copy link
Contributor

@honor-gfsc honor-gfsc commented May 28, 2024

Adds information about the GI website redo to the Our Work section of the website

@geeksforsocialchange/developers

@honor-gfsc honor-gfsc requested review from kimadactyl and katjam May 28, 2024 11:17
@kimadactyl
Copy link
Member

this is great but it sure would be nice to have a testimonial from jay to end it on? do we have one?

Copy link

cloudflare-workers-and-pages bot commented Jun 17, 2024

Deploying gfsc with  Cloudflare Pages  Cloudflare Pages

Latest commit: 49ce445
Status: ✅  Deploy successful!
Preview URL: https://686804fb.gfsc.pages.dev
Branch Preview URL: https://gi-nextdoor.gfsc.pages.dev

View logs

@honor-gfsc
Copy link
Contributor Author

this is great but it sure would be nice to have a testimonial from jay to end it on? do we have one?

Don't think we do at this stage

@honor-gfsc
Copy link
Contributor Author

This adds GI and Nextdoor Nature to the portfolio

@kimadactyl kimadactyl self-assigned this Nov 13, 2024
@kimadactyl kimadactyl changed the title Added gendered-intelligence-website to Our Work Add gendered-intelligence-website to Our Work Nov 22, 2024
@kimadactyl
Copy link
Member

kimadactyl commented Nov 25, 2024

@katjam - can you pull this and lmk if this is working on your machine please?

if i go to here locally, nothing shows up in the list of projects http://localhost:1313/our-work/theme/environment/

compare: https://686804fb.gfsc.pages.dev/our-work/theme/environment/

not sure if this is my hugo version or what but a bit unnerving!

@kimadactyl kimadactyl changed the title Add gendered-intelligence-website to Our Work Add GI and NDN to Our Work Nov 25, 2024
@kimadactyl
Copy link
Member

kimadactyl commented Nov 25, 2024

OK - I seem to have found the culprit

{{ $section := index (split .Path "/") 1 }}

This should be 2 not 1 - i.e. capture 'themes' not 'our-work', allowing the conditional to trigger on line 12 or 17. I am MYSTIFIED how it's working right now and what's changed for this to not work now. SURELY the 'split' function hasn't had it's API changed to be 1-indexed not 0-indexed? Have to clock off now but let me know if you can reproduce this

possible culprit

gohugoio/hugo@01b72eb#diff-bab7dfb438de0178f790ad857ca900784d49d0d5f670f10ca0ba81b1cb0fd40dR47

@katjam
Copy link
Member

katjam commented Nov 26, 2024

I don't have much time to poke around today but can confirm that I also get no listing on that page when I run that branch.

I am running hugo v0.138.0+extended linux/amd64 BuildDate=unknown

@kimadactyl
Copy link
Member

kimadactyl commented Nov 26, 2024

OK. I think the solution here is to just stick to the one version of Hugo the site runs on, too much work to change it, but does mean I need to juggle Hugo versions.

Thanks for checking and glad this isn't just me!

Even static sites need tests really huh

@katjam
Copy link
Member

katjam commented Nov 26, 2024

Yeah - is nuts how things change so much so quickly and so quietly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants