Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add void type Support #16 #20

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add void type Support #16 #20

wants to merge 3 commits into from

Conversation

sandorfr
Copy link
Member

@sandorfr sandorfr commented Jan 19, 2017 •
edited
Loading

TODO

  • fix Csharp Template : should return a Task
  • needs updated restkit dependency

@sandorfr sandorfr changed the title add void type #16 Add void type Support #16 Jan 19, 2017
sandorfr
sandorfr commented Jan 30, 2017
View reviewed changes
src/node-swagger-generator/lib/languages/csharp.ts
@@ -35,6 +35,10 @@ class CSharpAbstractedTypeConverter implements IAbstractedTypeConverter<IType> {

}

voidTypeConvert(type: SchemaLessAbstractedType): CSharpType {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be VoidAbstractedType

src/node-swagger-generator/lib/generation.ts
@@ -681,6 +681,9 @@ class GenericTypeConverter implements IAbstractedTypeConverter<IAbstractedType>{
constructor(private contextBuilder: ContextBuilder) {
}

voidTypeConvert(type: SchemaLessAbstractedType): IAbstractedType {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be VoidAbstractedType

src/node-swagger-generator/lib/languages/typescript.ts
@@ -35,6 +35,10 @@ class TypescriptAbstractedTypeConverter implements IAbstractedTypeConverter<ITyp

}

voidTypeConvert(type: SchemaLessAbstractedType): TypescriptType {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be VoidAbstractedType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sandorfr