-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ai-write-paper #1454
base: main
Are you sure you want to change the base?
ai-write-paper #1454
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
=======================================
Coverage 62.59% 62.59%
=======================================
Files 287 287
Lines 17589 17589
=======================================
Hits 11009 11009
Misses 6580 6580 ☔ View full report in Codecov by Sentry. |
Can you provide some running results and examples of what it can do? |
|
我的意思是,注意到 gradio 的实现,是否可以看一下运行过程和使用方法? |
大佬:
|
大佬:后续借鉴了qwen_agent仓库里的方法,做检索;代码稍微修改,修改大纲目录树结构,能递归式保留更细粒度子标题; |
参考 https://github.com/geekan/MetaGPT/blob/main/.pre-commit-config.yaml 这里安装一下 pre-commit,格式化一下代码 |
metagpt/ext/ai_writer/writer.py
Outdated
# Add the list of Document objects as nodes to the retriever engine | ||
self.store.retriever.add_nodes(doc_chunks) | ||
self.working_memory.clear() | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 使用 pre-commit
- 增加对应的测试用例
- 增加README.md,说明用法、设计思路、遗留问题等
安装pre-commit 存在问题,暂时未能解决,Readme已添加进仓库 |
.pre-commit-config.yaml
Outdated
@@ -1,4 +1,4 @@ | |||
default_stages: [ commit ] | |||
default_stages: [ pre-commit ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not modify this.
metagpt/ext/ai_writer/README.md
Outdated
|
||
**功能区** : 根据 当前`chapter_id` 章节序号, 输入润色指令进行润色;**联网:**从网络上获取当前当前标题相关网络信息; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't leave so many blank lines, generally leave only one blank line.
metagpt/ext/ai_writer/README.md
Outdated
|
||
|
||
|
||
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect input
metagpt/ext/ai_writer/app_demo.py
Outdated
@@ -0,0 +1,364 @@ | |||
import gradio as gr | |||
import json,os ,shutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use pre-commit. Or you can use the built-in function of vscode / pycharm to reformat. However, the submitted code needs to comply with most of the PEP8 standards, otherwise it will be difficult for us to accept it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been modified, please check again
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我查看了文件,根据以上 CR 意见,这些文件还需要进一步的修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,我已对README文件和.pre-commit-config.yaml 文件进行修订
Features
Feature Docs
Influence
写作方案
Result
Other