Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change approach on how serialized files are handled #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fitoprincipe
Copy link
Member

third attempt to fix #55

Copy link
Member

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main problem with these changes is that you basically don't rely on the pytest-regression function anymore. This function even if it looks heavy is dealing with every edge cases of naming composition pytests offers and I would like to continue getting advantage of their support.

The only issue is that we cannot catch the real error that occurs when the file is not there or not corresponding (when the directly call pytest.raise) let me try to reach out to them first and see if they are open to modify this behaviour to a more specific error that we would be able to catch with the supress.

@fitoprincipe
Copy link
Member Author

This is partially true; it's only avoiding pytest-regression when checking against the serialized object. This is the step when we need to make decisions, that's why I created the function that returns a boolean indicating only if the serialized object is the same as the saved one, avoiding all the extra condiments of pytest-regression. But still relies on it for the rest of the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serialized yaml is not created
2 participants