added ability to specify tableName on a model by model bases. Only works... #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rks with SQL adapters at the moment.
|
This looks good. Similar work is happening here: #151 Would it be possible for y'all to coordinate to make sure this stuff plays nicely together? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with SQL adapters at the moment. I only added it to SQL adapters at the moment because SQL was the only one that had a single place to check for table name. Also you can change the table name on a model instance or a model definition. I added it to the model definition so that it can be set on a framework level by setting the models table names when you load the models into your framework.