Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AREF __getitem__ for instance ports and generic route_bundle #484

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix AREF __getitem__ for instance ports and generic route_bundle #484

merged 2 commits into from
Oct 2, 2024

Conversation

sebastian-goeldi
Copy link
Collaborator

@sebastian-goeldi sebastian-goeldi commented Oct 2, 2024 •
edited
Loading

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Oct 2, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added bug Something isn't working routing labels Oct 2, 2024
sourcery-ai[bot]
sourcery-ai bot reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@sebastian-goeldi sebastian-goeldi merged commit d40f108 into main Oct 2, 2024
13 checks passed
@sebastian-goeldi sebastian-goeldi deleted the fix-aref-getitem-and-generic-router branch October 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
bug Something isn't working routing
Projects
None yet
Milestone
No milestone
1 participant
@sebastian-goeldi