add generic pdk #174
Closed
add generic pdk #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-goeldi
requested changes
Aug 14, 2023
|
Ok, I think this then actually makes sense to be implemented in kgeneric. I'll happily review there or write tests etc. Also, once done, and when the PR for lcl/pdk merge is done, we should link from kfactory to the kgeneric docs. The way I was thinking about it was to have a notebook in kfactory for a (or multiple) minimalistic implementation of a pdk (as a kcl when merged) and then link to kgeneric for a more general implementation. What do you think @joamatab ? |
|
Sounds like a plan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sebastian-goeldi