Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added footer styles #8

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Conversation

RaviTejaVattem
Copy link
Contributor

Addresses #2 .

Added styles for Footer.

Please check and let me know if you have any issues with it.

Copy link
Member

@meinhoonharsh meinhoonharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Implies changes on only bottom section in footer, could you please improve css for the whole footer displayed in screenshot in Issue Description

@meinhoonharsh
Copy link
Member

And since we've merged a PR due to which it is now having Merge conflicts, So It would be great if you get h current project and resolve the conflicts

@RaviTejaVattem
Copy link
Contributor Author

Styled About section along with the footer.

@meinhoonharsh please check and let me know if it is okay.

Copy link
Member

@meinhoonharsh meinhoonharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Perfect to Merge,
Sorry for the Delay, because the Event was not officially started yet

@meinhoonharsh meinhoonharsh merged commit 03e622d into gdscrgpv:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants