feat: add gdsc-grass component #27
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ballsona
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Comment on lines
+33
to
+46
| <rect | ||
| data-level={level} | ||
| className={styles.grassGraphItemStyle[level]} | ||
| x={x} | ||
| y={y} | ||
| rx="2" | ||
| ry="2" | ||
| width="13" | ||
| height="13" | ||
| onMouseEnter={handleMouseEnter} | ||
| onMouseLeave={onMouseLeave} | ||
| > | ||
| {infoText} | ||
| </rect> |
There was a problem hiding this comment.
오 div 말고 rect 를 쓰신 이유는 많은 요소들을 렌더링할때 svg가 더 빨라서인가요??
There was a problem hiding this comment.
ㅋㅋㅋ와 이거 그래프 구현하기 꽤 어렵겠다 생각했는데,, 역시,, 👍 이강현이 이강현했네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9
Description
외부 서비스 팀의 Github Contest 파트의 "GDSC 잔디" 컴포넌트 개발 관련 PR입니다.
아직 스타일 관련(색상, 폰트 등) constants 작업이 이루어지지 않아 Figma의 디자인에 따라 작업하였으며, 추후에 constants 작업이 완성되면 main 브랜치를 rebase하고 추가 작업하여 업로드하겠습니다.
(반응형 디자인도 일부 작업하였으나, 폰트 크기 같은 부분은 constatns 작업 이후 위의 추가 작업 때 반영하겠습니다.)
위 사항들을 제외한 나머지 요소들에 대해 리뷰 부탁드리겠습니다:)
피드백 언제든지 환영이요!! (얘기하고 싶은거 다 얘기해주세요ㅎ)
Check List
main브랜치의 최신 상태를 반영하고 있는지 확인