Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Set Login Redirection #64

Merged
merged 2 commits into from
Jan 1, 2025
Merged

[Fix] Set Login Redirection #64

merged 2 commits into from
Jan 1, 2025

Conversation

goldentrash
Copy link
Contributor

배경

OAuth로 사용자 인증을 이주했는데, 막상 로그인 성공 후 redirection을 설정하지 않은 상황입니다. 그래서 로그인을 성공한 후 SPA로 사용자가 재진입하도록 redirection을 설정합니다.

부가

resolve #59

아무래도 Server Static Page를 만들지 않기로 합의한 상황에서는 상수화를 통한 컨트롤이 가장 단순하다고 생각하여 적용합니다. 이 과정에서 Constants 패키지를 조금 더 잘게 세분화했습니다.

@goldentrash goldentrash added bug Something isn't working enhancement New feature or request labels Dec 31, 2024
@goldentrash goldentrash requested a review from ekgns33 December 31, 2024 08:30
@goldentrash goldentrash self-assigned this Dec 31, 2024
Copy link
Collaborator

@ekgns33 ekgns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 확인했숨돠

@goldentrash goldentrash merged commit 1748555 into main Jan 1, 2025
3 checks passed
@goldentrash goldentrash deleted the fix/oauth-redirection branch January 1, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

출석 성공 리디렉션 리팩터링
2 participants