Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] late attendance #55

Merged
merged 4 commits into from
Nov 29, 2024
Merged

[Feat] late attendance #55

merged 4 commits into from
Nov 29, 2024

Conversation

goldentrash
Copy link
Contributor

하고자 한 일

  • 출석에 지각 추가
  • QR을 통한 출석은 "출석"과 "결석"만 가능하고, "지각"은 추후 운영진이 수동으로 선택하는 옵션
  • 출석 현황과 출석비율 등을 반영할 때에, "지각"은 "출석"과 마찬가지로 취급
  • Event 삭제가 반영되지 않은 DTO에 eventId와 같은 속성 제거

@goldentrash goldentrash requested a review from ekgns33 November 27, 2024 14:29
@goldentrash goldentrash self-assigned this Nov 27, 2024
@goldentrash goldentrash mentioned this pull request Nov 27, 2024
Open
ekgns33
ekgns33 requested changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@ekgns33 ekgns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 통계 API만 따로 이야기해여!

src/main/java/gdsc/konkuk/platformcore/application/attendance/dtos/MemberAttendanceInfo.java Show resolved Hide resolved
src/main/java/gdsc/konkuk/platformcore/application/member/dtos/MemberAttendances.java Show resolved Hide resolved
src/main/java/gdsc/konkuk/platformcore/domain/attendance/entity/Participant.java Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
31.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@goldentrash goldentrash requested a review from ekgns33 November 29, 2024 08:50
@goldentrash goldentrash merged commit 137071f into main Nov 29, 2024
2 checks passed
@goldentrash goldentrash deleted the feat/late-attendance branch November 29, 2024 11:56
@goldentrash goldentrash mentioned this pull request Dec 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekgns33 ekgns33 ekgns33 approved these changes

Assignees

@goldentrash goldentrash

Labels
feature size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldentrash @ekgns33