Feat : member register #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경점
MemberFixture가 dummy password가 아닌, 실제PasswordEncoder로 인코딩한 password를 사용하도록 수정사용자 회원가입은 미완의 기능입니다!
우리는 사전에 등록된 사용자만 회원가입에 성공하도록 제한해야 합니다. 따라서 DB에 저장된
Member중Admin권한을 가진 사용자에 한해서 회원가입을 진행해야 합니다. 현 PR에서는, password가 초깃값("")일 경우에 한해 password를 변경 허용하는 방향으로 회원가입을 진행합니다. 이 방법은 다음의 문제가 있습니다.Admin계정을 처음으로 접속할 경우 사용자 본인 확인 없이 회원가입이 가능합니다.회원정보 수정기능이 구현되어있지 않다고 생각할수도 있습니다.