Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run prettier with lint-staged #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ci: run prettier with lint-staged #27

wants to merge 2 commits into from

Conversation

seo-rii
Copy link
Member

@seo-rii seo-rii commented Jan 13, 2024

Removes github actions and run prettier locally in pre-commit stage with husky.

@Byunk
Copy link
Collaborator

Byunk commented Jan 14, 2024

@seo-rii Nice work! Thanks for your contribution.

한가지 우려사항이 있는데요 prettier를 pre-commit hook에 적용시키는 것에 대해서는 동의하지만, 동시에 CI pipeline에서 검증하는 과정은 남겨두는 것이 좋지 않을까 싶네요.

  1. pre-commit hook은 bypass 될 가능성이 존재함.
  2. pre-commit hook은 commit --amend에서 trigger 되지 않음.

다시 한번 contribution에 감사드립니다. 좋은 방향이네요!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally think that CI pipeline for prettier has to be remained even with husky.

@Byunk Byunk self-assigned this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants