Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdr 2371 #47

Merged
merged 12 commits into from
Feb 20, 2024
Merged

Gdr 2371 #47

merged 12 commits into from
Feb 20, 2024

Conversation

gladkia
Copy link
Contributor

@gladkia gladkia commented Feb 14, 2024

@gladkia gladkia requested a review from a team as a code owner February 14, 2024 13:45
@gladkia gladkia requested review from marcin-kam and j-smola and removed request for a team February 14, 2024 13:45
Copy link
Contributor

@j-smola j-smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update package version:
gDRstyle 1.1.3
gDRtestData 1.1.7
gDRutils 1.1.5
gDRcore 1.1.11
gDRimport 1.1.4

and
RoxygenNote: 7.3.0

_pkgdown.yml Outdated Show resolved Hide resolved
@gladkia
Copy link
Contributor Author

gladkia commented Feb 15, 2024

Please, update package version: gDRstyle 1.1.3 gDRtestData 1.1.7 gDRutils 1.1.5 gDRcore 1.1.11 gDRimport 1.1.4

and RoxygenNote: 7.3.0

done.

@gladkia Please, also update in DESCRIPTION :)

@j-smola
Copy link
Contributor

j-smola commented Feb 15, 2024

Please, also think how to solve issue with README gDRverse scheme. In pkgdown site it is cropped :(
_scheme

@gladkia
Copy link
Contributor Author

gladkia commented Feb 15, 2024

Please, also think how to solve issue with README gDRverse scheme. In pkgdown site it is cropped :( _scheme

Fixed.

@gladkia gladkia merged commit 2204e98 into main Feb 20, 2024
3 of 4 checks passed
@gladkia gladkia deleted the GDR-2371 branch February 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants