This repository has been archived by the owner on Jan 9, 2022. It is now read-only.
AttributeError: 'NoneType' object has no attribute 'get' #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR fixes issues #7
Reason: Small backups(a couple of megabytes) didn't got such error, but backups which I have (partial backup 130mb, full backup 1gb) got error. Supervisor didn't return 200 response on
f"/snapshots/{slug}/info"
some time after file is created(for 130mb it takes some seconds on my installation, for 1GB 2-4 minutes).Solution: added retry strategy, I think it is impovement for stability, when supervisor api doesn't work because of some reason
Log of supervisor after fix, we see that file is created at 12:31:14 but snapshot creation completed at 12:35:13, extension got snapshot sucessfully at 12:35:35(6 attempt)
Also this pr contains small fix of (#5) Looks like some alpine repo updated and now we got incorrect installation of boto3, I've installed it from pip