some improvement for systemctl3.py #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAT_CMD
to a list of candidatesCAT_CMDS
and search for the first existing path. Same change forLESS_CMD
andTAIL_CMD
.log_unit_from
, instead ofspawnvp
a new process forcat
/tail
/less
, I useexecvp
to replace current process. By doing this,systemctl
needn't to handle the exit code and errors.For example, before this PR, when I use
systemctl log -f service
to see the log and then use ctrl+c to exit, I will get an ugly error like this. But when this PR is accepted, the tail command will exit directly and no error will show.