Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BO01 - Create a layout for the BackOffice #170

Merged
merged 13 commits into from
May 22, 2024
Merged

BO01 - Create a layout for the BackOffice #170

merged 13 commits into from
May 22, 2024

Conversation

valekuro
Copy link
Contributor

Created Layout component, Header component and Sidebar component.

The issue is not completed!!

This PR is submitted for showing work in progress purposes.
Actual bug:

  • Ipad Mini e Ipad Air in landscape the drawer not working well
  • In desktop mode the menu is not in overlay
  • I used letters instead of icons because I don't know if we want to use fontawesome or custom icons

gregoriopalama
gregoriopalama requested changes Apr 16, 2024
View reviewed changes
src/feature-header/Header.tsx Outdated Show resolved Hide resolved
src/feature-sidebar/Sidebar.tsx Outdated Show resolved Hide resolved
src/feature-sidebar/SidebarItems.tsx Outdated Show resolved Hide resolved
src/feature-sidebar/SidebarItems.tsx Outdated Show resolved Hide resolved
src/layouts/Layout.astro Outdated Show resolved Hide resolved
src/pages/index.astro Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Playwright test results

passed  3 passed

Details

stats  3 tests across 1 suite
duration  5.7 seconds
commit  2a7d448

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

Lighthouse ran against http://localhost:4321/

gregoriopalama
gregoriopalama requested changes May 6, 2024
View reviewed changes
src/backoffice-layout/Sidebar.astro Outdated Show resolved Hide resolved
src/backoffice-layout/Sidebar.astro Outdated Show resolved Hide resolved
src/pages/index.astro Outdated Show resolved Hide resolved
@valekuro
Copy link
Contributor Author

PR ready! @gregoriopalama @irsooti
I used Iconify and astro-icon.
To choose icons visit: Icon-sets and choose "Material Design Icon".

gregoriopalama
gregoriopalama requested changes May 20, 2024
View reviewed changes
src/pages/index.astro Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, reset this to the version that is actually on main

@gregoriopalama gregoriopalama marked this pull request as ready for review May 22, 2024 14:32
@gregoriopalama gregoriopalama merged commit 901a8ff into gdgpescara:main May 22, 2024
10 checks passed
@gregoriopalama gregoriopalama mentioned this pull request May 23, 2024
Closed
camillobucciarelli pushed a commit that referenced this pull request Jun 9, 2024
Merge branch 'main' into USER04
8a5ca93 
* main:
  BO01 - Create a layout for the BackOffice (#170)
  BO42 - Create utility to query Firestore with pagination (#230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregoriopalama gregoriopalama gregoriopalama approved these changes

@irsooti irsooti Awaiting requested review from irsooti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valekuro @irsooti @gregoriopalama