Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Simulator State Change #277

Merged
merged 11 commits into from
Jul 3, 2024
Merged

[Fix] Simulator State Change #277

merged 11 commits into from
Jul 3, 2024

Conversation

lucasvillaverde
Copy link
Contributor

@lucasvillaverde lucasvillaverde commented Jul 3, 2024 •
edited
Loading

Summary

  • Fix simulator state change;
  • Fix button actions and adding directiosn (forward, backward, up, down);
  • Removing some unused methods and useless method calls;
  • Fix orientation issue.

How It Was Tested

Screenshot/Gif

SIMULATOR.MODE.mp4
Screenshot Name

@lucasvillaverde lucasvillaverde marked this pull request as ready for review July 3, 2024 14:00
mariobodemann
mariobodemann approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@mariobodemann mariobodemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTC(cketti)

@mariobodemann mariobodemann added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 3, 2024
@mariobodemann mariobodemann merged commit 6d0dd28 into gdg-berlin-android:main Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobodemann mariobodemann mariobodemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasvillaverde @mariobodemann