Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default sparsity check in DIT #569

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Disable default sparsity check in DIT #569

merged 1 commit into from
Oct 10, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Oct 10, 2024

Version

  • Bump DIT to v0.8.1

DIT source

  • Set sparsity=false in test_differentiation by default. Counting nonzeros exactly fails for finite differences!

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (7607ec2) to head (0571e85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   98.00%   97.98%   -0.03%     
==========================================
  Files         108      108              
  Lines        4812     4812              
==========================================
- Hits         4716     4715       -1     
- Misses         96       97       +1     
Flag Coverage Δ
DI 98.66% <ø> (ø)
DIT 96.62% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 45fbdd6 into main Oct 10, 2024
43 checks passed
@gdalle gdalle deleted the gd/nosparsity branch October 10, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants