Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dy=true for gradient (smallest possible 1) #363

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Use dy=true for gradient (smallest possible 1) #363

merged 1 commit into from
Jul 17, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Jul 17, 2024

DI source

  • Replace dy = one(eltype(x)) (which doesn't work for non-arrays) with dy = true for the pullback that defines gradient
  • Modify a few type annotations

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (63fa856) to head (1bc0dde).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   96.57%   96.57%   -0.01%     
==========================================
  Files          98       98              
  Lines        4813     4811       -2     
==========================================
- Hits         4648     4646       -2     
  Misses        165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit a86ebb8 into main Jul 17, 2024
51 checks passed
@gdalle gdalle deleted the gd/gradspeed branch July 17, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants