Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated f for Enzyme to handle closures #341

Closed
wants to merge 1 commit into from
Closed

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Jun 27, 2024

Fix #339

@gdalle gdalle added the backend Related to one or more autodiff backends label Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 71 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (ff529cb) to head (337cb5c).

Files Patch % Lines
...ifferentiationInterfaceEnzymeExt/reverse_onearg.jl 0.00% 29 Missing ⚠️
...ifferentiationInterfaceEnzymeExt/forward_onearg.jl 0.00% 26 Missing ⚠️
...ifferentiationInterfaceEnzymeExt/reverse_twoarg.jl 0.00% 10 Missing ⚠️
...ifferentiationInterfaceEnzymeExt/forward_twoarg.jl 0.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ff529cb) and HEAD (337cb5c). Click for more details.

HEAD has 68 uploads less than BASE | Flag | BASE (ff529cb) | HEAD (337cb5c) | |------|------|------| ||99|31|
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   96.77%   90.61%   -6.16%     
==========================================
  Files         101       99       -2     
  Lines        4831     4836       +5     
==========================================
- Hits         4675     4382     -293     
- Misses        156      454     +298     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses
Copy link

wsmoses commented Jun 28, 2024

This has highly non-trivial implications -- especially if you only support multi arguments etc via closures.

This will likely result in significant perf downgrades for folks, please do not merge if you want to maintain performance for downstream users.

@gdalle
Copy link
Owner Author

gdalle commented Jul 22, 2024

Superseded by #375

@gdalle gdalle closed this Jul 22, 2024
@gdalle gdalle deleted the gd/enzyme_closures branch July 31, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to one or more autodiff backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Enzyme dispatches compatible with closures
3 participants