Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4025 - Use async_trait for LoggingObjectStore #4026

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Issue 4025 - Use async_trait for LoggingObjectStore #4026

merged 5 commits into from
Jan 8, 2025

Conversation

patchwork01
Copy link
Collaborator

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • Covered by existing tests

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

@patchwork01 patchwork01 added the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Jan 7, 2025
@patchwork01 patchwork01 mentioned this pull request Jan 7, 2025
Merged
4 tasks
@gaffer01 gaffer01 removed their assignment Jan 7, 2025
Base automatically changed from 3974-refactored-object-store-logging-for-datafusion-compaction to develop January 8, 2025 08:58
@patchwork01 patchwork01 merged commit bd06106 into develop Jan 8, 2025
5 checks passed
@patchwork01 patchwork01 deleted the 4025-async-trait branch January 8, 2025 08:59
@patchwork01 patchwork01 mentioned this pull request Jan 8, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m09526 m09526 m09526 approved these changes

@gaffer01 gaffer01 gaffer01 approved these changes

Assignees
No one assigned
Labels
pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use async_trait in object store logging
4 participants
@patchwork01 @gaffer01 @m09526 @rtjd6554