Validate sqsqueues includes all queue properties #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patchwork01
reviewed
Dec 17, 2024
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class SQSTest { |
There was a problem hiding this comment.
We could call this SqsQueuesTest?
Comment on lines
43
to
45
| Field[] interfaceFields = CdkDefinedInstanceProperty.class.getFields(); | ||
| for (Field f : interfaceFields) { | ||
| CdkDefinedInstanceProperty present = (CdkDefinedInstanceProperty) f.get(this); |
There was a problem hiding this comment.
There's a function CdkDefinedInstanceProperty.getAll, the reflection isn't needed.
rtjd6554
changed the title
patchwork01
approved these changes
Dec 17, 2024
rtjd6554
deleted the
3907-validate-sqsqueues-includes-all-queue-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
PR"
Tests
Documentation
separate issue for that below.