Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3689 - Lambda code for compaction job dispatch #3749

Merged
merged 12 commits into from
Nov 21, 2024

Conversation

rtjd6554
Copy link
Collaborator

@rtjd6554 rtjd6554 commented Nov 20, 2024

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • CompactionJobDispatchLambdaIT

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

@rtjd6554 rtjd6554 linked an issue Nov 20, 2024 that may be closed by this pull request
@patchwork01 patchwork01 marked this pull request as ready for review November 21, 2024 10:53
@patchwork01 patchwork01 changed the title Lambda code for compaction job dispatch Issue 3689 - Lambda code for compaction job dispatch Nov 21, 2024
@patchwork01 patchwork01 added the pr-base-for-stacking Base for stacked pull requests (a dependency for others, where this PR's branch will be the base) label Nov 21, 2024
import static sleeper.core.properties.instance.CdkDefinedInstanceProperty.COMPACTION_PENDING_QUEUE_URL;
import static sleeper.core.properties.instance.CdkDefinedInstanceProperty.CONFIG_BUCKET;

public class CompactionJobDispatchLambda implements RequestHandler<SQSEvent, Void> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have some Javadoc for this class.

@gaffer01 gaffer01 assigned gaffer01 and rtjd6554 and unassigned gaffer01 Nov 21, 2024
@patchwork01 patchwork01 merged commit 0c353ec into develop Nov 21, 2024
9 checks passed
@patchwork01 patchwork01 deleted the 3689-lambda-code-for-compaction-job-dispatch branch November 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-base-for-stacking Base for stacked pull requests (a dependency for others, where this PR's branch will be the base)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda code for compaction job dispatch
3 participants