Issue 3329 - Lookup EC2 sizes at runtime #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ookup-EC2-instance-stats-at-runtime
…329-lookup-EC2-instance-stats-at-runtime
patchwork01
added
the
pr-base-for-stacking
patchwork01
approved these changes
Nov 20, 2024
gaffer01
reviewed
Nov 20, 2024
| // advertised by an EC2 instance to accommodate this. This ensures we will create enough instances to hold | ||
| // the desired number of containers. ECS will then be able to avoid allocating too many containers on to a | ||
| // single instance. | ||
| long memoryMiB = (long) (typeInfo.getMemoryInfo().getSizeInMiB() * 0.9); |
There was a problem hiding this comment.
Is it worth adding a separate issue to make this 0.9 configurable?
There was a problem hiding this comment.
gaffer01
approved these changes
Nov 20, 2024
patchwork01
reviewed
Nov 21, 2024
java/common/common-task/src/main/java/sleeper/task/common/EC2Scaler.java
Outdated
Show resolved
Hide resolved
java/common/common-task/src/main/java/sleeper/task/common/RunCompactionTasks.java
Outdated
Show resolved
Hide resolved
patchwork01
approved these changes
Nov 21, 2024
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To find the correct number of containers per EC2 instance when scaling, we now look that information up at runtime from AWS.
Issue
PR"
Tests
EC2Scaler doesn't currently have unit tests.
Documentation
This is an improvement to correct a flaw in the previous design.