Issue 3477 - Rust compaction integration tests #3580

patchwork01 · 2024-10-30T09:21:50Z

Make sure you have checked all steps below.

My PR addresses the following issues and references them in the PR title. For example, "Issue 1234 - My Sleeper
PR"
- Resolves Rust integration tests for DataFusion compaction #3477

My PR adds the following tests OR does not need testing for this extremely good reason:
- compaction_test.rs

In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
separate issue for that below.

.github/workflows/rust-tests.yaml

patchwork01 added 13 commits October 29, 2024 13:57

Set up compaction_test.rs

40ee079

Specify region in integration test

27f2576

Refactor should_merge_two_files

83d7076

Extract single_int_range

6940ff0

Avoid unwraps in tests

e764b0e

Read whole file in compaction test

862ad64

Add further tests with one int field

04c13a9

Run cargo test in GitHub Actions

6cd06f9

Extract write_file, writer_props

151c462

Extract int_range

be3f2e6

Use String::from

53125cb

Test multidimensional region

115ba88

Extract batch_of_int_fields

023c1c7

patchwork01 marked this pull request as ready for review October 30, 2024 11:58

patchwork01 assigned gaffer01, ab295382 and rtjd6554 and unassigned gaffer01 Oct 30, 2024

Extract compaction_helpers

f681a01

rtjd6554 reviewed Oct 30, 2024

View reviewed changes

.github/workflows/rust-tests.yaml Show resolved Hide resolved

ab295382 approved these changes Oct 31, 2024

View reviewed changes

patchwork01 unassigned ab295382 Oct 31, 2024

rtjd6554 removed their assignment Nov 4, 2024

rtjd6554 approved these changes Nov 4, 2024

View reviewed changes

gaffer01 approved these changes Nov 5, 2024

View reviewed changes

gaffer01 assigned patchwork01 and unassigned gaffer01 Nov 5, 2024

patchwork01 merged commit a68a189 into develop Nov 5, 2024
5 checks passed

patchwork01 deleted the 3477-rust-integration-tests branch November 5, 2024 14:26

Provide feedback