Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3448 - Failure with no output when running sleeper cli without images #3562

Closed
wants to merge 1 commit into from
Closed

3448 - Failure with no output when running sleeper cli without images #3562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/cli/runInDocker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ build_temp_runner_image() {
local SET_DOCKER_GID=$(getent group docker | cut -d: -f3)
TEMP_RUNNER_IMAGE="sleeper-runner:$TEMP_TAG"
echo "Propagating current user to Docker image"
docker build "$RUNNER_PATH" --quiet -t "$TEMP_RUNNER_IMAGE" \
docker build "$RUNNER_PATH" -t "$TEMP_RUNNER_IMAGE" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me removing the quiet flag seems to result in too much output for the simplest CLI operation. I'd rather just close this and leave the bug open until we find another way. You could take it off the milestone for now, but please add any information you've found about the problem.

Do you think this change is a good idea?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is useful if the details provided have a meaningful impact on the issue.
Given that the information returned from the interaction without the flag is large, my view would align with yours that the output is excessive for the cli operation. Will close down review as not needed and provide details on parent tickets around conclusion so possible discussion of what might be needed for another approach

--build-arg RUN_IMAGE="$RUN_IMAGE" \
--build-arg SET_UID=$SET_UID \
--build-arg SET_GID=$SET_GID \
Expand Down
Loading