Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2276 - Limit size of state store provider cache #2440

Merged
merged 10 commits into from
May 7, 2024
Merged

Issue 2276 - Limit size of state store provider cache #2440

merged 10 commits into from
May 7, 2024

Conversation

kr565370
Copy link
Collaborator

@kr565370 kr565370 commented May 2, 2024 •
edited
Loading

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • StateStoreProviderWithSizeTest

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added, removed, or updated any external dependencies used in the project, I have updated the
    NOTICES file to reflect this.

@kr565370 kr565370 changed the title Issue 2276 Limit size of state store provider cache Issue 2276 - Limit size of state store provider cache May 2, 2024
patchwork01
patchwork01 approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@patchwork01 patchwork01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if we remove the extra method. Assuming we'll replace the current implementation as a separate issue.

@patchwork01 patchwork01 assigned kr565370 and unassigned patchwork01 May 3, 2024
@kr565370 kr565370 marked this pull request as ready for review May 3, 2024 13:36
@kr565370 kr565370 assigned gaffer01 and unassigned kr565370 May 7, 2024
@gaffer01 gaffer01 removed their assignment May 7, 2024
@kr565370 kr565370 merged commit 899f71a into develop May 7, 2024
15 checks passed
@kr565370 kr565370 deleted the 2276-limit-size-of-cached-state-store-provider branch May 7, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patchwork01 patchwork01 patchwork01 requested changes

@gaffer01 gaffer01 gaffer01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit number of state stores cached in provider
3 participants
@kr565370 @gaffer01 @patchwork01