Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2271 - Load latest snapshot when first using transaction log state store #2355

Merged
merged 26 commits into from
Apr 26, 2024
Merged

Issue 2271 - Load latest snapshot when first using transaction log state store #2355

merged 26 commits into from
Apr 26, 2024

Conversation

kr565370
Copy link
Collaborator

@kr565370 kr565370 commented Apr 22, 2024 •
edited
Loading

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • TransactionLogStateStoreDynamoDBSpecificIT.LoadLatestSnapshots
    • Tested in AWS

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added, removed, or updated any external dependencies used in the project, I have updated the
    NOTICES file to reflect this.

@kr565370 kr565370 added the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Apr 22, 2024
@kr565370 kr565370 marked this pull request as ready for review April 23, 2024 10:07
@kr565370
Merge branch '2272-track-transactionlog-snapshots-in-dynamodb' into 2…
5d692e6 
…271-load-latest-snapshot-when-first-using-transactionlog-store
Base automatically changed from 2272-track-transactionlog-snapshots-in-dynamodb to develop April 23, 2024 10:26
@kr565370 kr565370 removed the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Apr 23, 2024
@kr565370 kr565370 added the pr-base-for-stacking Base for stacked pull requests (a dependency for others) label Apr 23, 2024
patchwork01
patchwork01 reviewed Apr 24, 2024
View reviewed changes
java/cdk/src/main/java/sleeper/cdk/stack/TransactionLogStateStoreStack.java Outdated Show resolved Hide resolved
...estore/src/test/java/sleeper/statestore/transactionlog/TransactionLogStateStoreTestBase.java Outdated Show resolved Hide resolved
...estore/src/main/java/sleeper/statestore/transactionlog/DynamoDBTransactionLogStateStore.java Outdated Show resolved Hide resolved
...estore/src/main/java/sleeper/statestore/transactionlog/DynamoDBTransactionLogStateStore.java Outdated Show resolved Hide resolved
...estore/src/main/java/sleeper/statestore/transactionlog/DynamoDBTransactionLogStateStore.java Outdated Show resolved Hide resolved
...tatestore/src/test/java/sleeper/statestore/transactionlog/TransactionLogSnapshotSerDeIT.java Outdated Show resolved Hide resolved
@patchwork01 patchwork01 assigned kr565370 and unassigned patchwork01 and gaffer01 Apr 24, 2024
@patchwork01 patchwork01 assigned patchwork01 and unassigned kr565370 Apr 24, 2024
@patchwork01 patchwork01 assigned gaffer01 and unassigned patchwork01 Apr 25, 2024
@gaffer01 gaffer01 removed their assignment Apr 26, 2024
@kr565370 kr565370 merged commit 3c533c6 into develop Apr 26, 2024
15 checks passed
@kr565370 kr565370 deleted the 2271-load-latest-snapshot-when-first-using-transactionlog-store branch April 26, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patchwork01 patchwork01 patchwork01 approved these changes

@gaffer01 gaffer01 gaffer01 approved these changes

Assignees

@kr565370 kr565370

Labels
pr-base-for-stacking Base for stacked pull requests (a dependency for others)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load latest snapshot when first using transaction log state store
3 participants
@kr565370 @gaffer01 @patchwork01