Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1961 - Update compaction job status store in CompactionTask #1971

Merged
merged 22 commits into from
Mar 11, 2024
Merged

Issue 1961 - Update compaction job status store in CompactionTask #1971

merged 22 commits into from
Mar 11, 2024

Conversation

kr565370
Copy link
Collaborator

@kr565370 kr565370 commented Mar 6, 2024 •
edited
Loading

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • Updated CompactionTest.UpdateStatusStores tests

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added, removed, or updated any external dependencies used in the project, I have updated the
    NOTICES file to reflect this.

Base automatically changed from 1963-simplify-interfaces-in-ingesttask to develop March 6, 2024 16:34
@kr565370 kr565370 added the pr-base-for-stacking Base for stacked pull requests (a dependency for others) label Mar 6, 2024
@gaffer01 gaffer01 removed their assignment Mar 7, 2024
@kr565370 kr565370 removed the pr-base-for-stacking Base for stacked pull requests (a dependency for others) label Mar 11, 2024
@kr565370 kr565370 marked this pull request as draft March 11, 2024 11:20
@kr565370 kr565370 changed the title Issue 1961 - Update ingest job status store in IngestJobRunner Issue 1961 - Update compaction job status store in CompactionTask Mar 11, 2024
@kr565370 kr565370 force-pushed the 1961-update-job-status-store-in-ingestjobrunner branch from 1574ffd to f903894 Compare March 11, 2024 11:59
@patchwork01 patchwork01 assigned kr565370 and unassigned patchwork01 Mar 11, 2024
@kr565370 kr565370 marked this pull request as ready for review March 11, 2024 12:36
@kr565370 kr565370 assigned patchwork01 and unassigned kr565370 Mar 11, 2024
@patchwork01 patchwork01 assigned kr565370 and unassigned patchwork01 Mar 11, 2024
@kr565370 kr565370 assigned patchwork01 and unassigned kr565370 Mar 11, 2024
@patchwork01 patchwork01 assigned kr565370 and unassigned patchwork01 Mar 11, 2024
@patchwork01 patchwork01 merged commit 31cbe9e into develop Mar 11, 2024
5 checks passed
@patchwork01 patchwork01 deleted the 1961-update-job-status-store-in-ingestjobrunner branch March 11, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patchwork01 patchwork01 patchwork01 approved these changes

@gaffer01 gaffer01 gaffer01 approved these changes

Assignees

@kr565370 kr565370

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make CompactionTask responsible for updating compaction job status store
3 participants
@kr565370 @gaffer01 @patchwork01