Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1353 - Table metrics for all tables #1380

Merged
merged 21 commits into from
Oct 2, 2023
Merged

Issue 1353 - Table metrics for all tables #1380

merged 21 commits into from
Oct 2, 2023

Conversation

patchwork01
Copy link
Collaborator

@patchwork01 patchwork01 commented Sep 28, 2023 •
edited by kr565370
Loading

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • TableMetricsTest
    • Ran system tests

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added, removed, or updated any external dependencies used in the project, I have updated the
    NOTICES file to reflect this.

@patchwork01 patchwork01 added the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Sep 28, 2023
kr565370 and others added 19 commits September 28, 2023 12:38
@kr565370
Add table metrics test for one table with multiple partitions
5581726
@kr565370
Add table metrics test for one file in one partition
293bf13
@kr565370
Merge branch '1352-s3-state-store-for-all-tables' into 1353-table-met…
d70eae6 
…rics-for-all-tables
@patchwork01
Merge branch '1352-s3-state-store-for-all-tables' into 1353-table-met…
e4fc448 
…rics-for-all-tables
@patchwork01
Merge branch '1352-s3-state-store-for-all-tables' into 1353-table-met…
8a8bc28 
…rics-for-all-tables
@patchwork01
Move tests under nested class SingleTable
f65c930
@kr565370
Add test for multiple files with different record counts
bfabbea
@kr565370
Simplify test for multiple files with different record counts
6e85f57
@kr565370
Add test for multiple partitions with different file counts
989dea5
@kr565370
Add test for multiple partitions where one leaf has no files
fcb3eaa
@patchwork01
Test multiple tables
e988bbf
@patchwork01
Remove extra test helper
d6e45e6
@patchwork01
Use TableMetrics in TableMetricsLambda
d33b180
@kr565370
Merge branch '1352-s3-state-store-for-all-tables' into 1353-table-met…
03797b0 
…rics-for-all-tables
@kr565370
Merge branch '1352-s3-state-store-for-all-tables' into 1353-table-met…
c2d3233 
…rics-for-all-tables
@kr565370
Create and use nested stack for TableMetricsStack
eb4b42c
@patchwork01
Merge branch '1352-s3-state-store-for-all-tables' into 1353-table-met…
776cfb3 
…rics-for-all-tables

# Conflicts:
#	java/cdk/src/main/java/sleeper/cdk/stack/TableStack.java
@patchwork01
Read TableMetrics as a stream
ea62424
@patchwork01
Avoid collecting TableMetrics for all tables at once
90a2a2b
@patchwork01 patchwork01 marked this pull request as ready for review September 29, 2023 11:51
@patchwork01 patchwork01 added pr-stacked-middle A stacked pull request that must wait until the target PR is merged, and is also a base for stacking and removed pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged labels Sep 29, 2023
Base automatically changed from 1352-s3-state-store-for-all-tables to main October 2, 2023 11:22
@kr565370 kr565370 added pr-base-for-stacking Base for stacked pull requests (a dependency for others) and removed pr-stacked-middle A stacked pull request that must wait until the target PR is merged, and is also a base for stacking labels Oct 2, 2023
@kr565370 kr565370 merged commit 70ce447 into main Oct 2, 2023
15 checks passed
@kr565370 kr565370 deleted the 1353-table-metrics-for-all-tables branch October 2, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr565370 kr565370 kr565370 approved these changes

@gaffer01 gaffer01 gaffer01 approved these changes

Assignees
No one assigned
Labels
pr-base-for-stacking Base for stacked pull requests (a dependency for others)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy one table metrics Lambda for all tables
3 participants
@patchwork01 @gaffer01 @kr565370