Issue 1352 - One S3 state store for all tables #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr565370
added
the
pr-stacked-top
patchwork01
added
pr-stacked-middle
…state-store-for-all-tables # Conflicts: # java/statestore/src/main/java/sleeper/statestore/s3/S3PartitionStore.java # java/statestore/src/main/java/sleeper/statestore/s3/S3StateStoreCreator.java # java/statestore/src/test/java/sleeper/statestore/s3/S3StateStoreIT.java
…es' into 1352-s3-state-store-for-all-tables
…state-store-for-all-tables # Conflicts: # java/statestore/src/main/java/sleeper/statestore/s3/S3PartitionStore.java
…state-store-for-all-tables
…state-store-for-all-tables # Conflicts: # java/cdk/src/main/java/sleeper/cdk/stack/TableStack.java
patchwork01
reviewed
Sep 29, 2023
java/statestore/src/main/java/sleeper/statestore/s3/S3PartitionStore.java
Outdated
Show resolved
Hide resolved
…state-store-for-all-tables # Conflicts: # java/cdk/src/main/java/sleeper/cdk/stack/TableStack.java # java/statestore/src/main/java/sleeper/statestore/s3/S3FileInfoStore.java # java/statestore/src/main/java/sleeper/statestore/s3/S3PartitionStore.java # java/statestore/src/main/java/sleeper/statestore/s3/S3RevisionUtils.java
gaffer01
reviewed
Sep 29, 2023
| this.keySerDe = new KeySerDe(rowKeyTypes); | ||
| this.fileSchema = initialiseFileInfoSchema(); | ||
| this.conf = builder.conf; | ||
| this.s3RevisionUtils = new S3RevisionUtils(dynamoDB, dynamoRevisionIdTable); | ||
| this.s3RevisionUtils = new S3RevisionUtils(builder.dynamoDB, builder.dynamoRevisionIdTable, builder.sleeperTable); |
There was a problem hiding this comment.
sleeperTable is set on the builder and then used to create this S3RevisionUtils. The s3Path variable is created outside of this class and also contains sleeperTable. It might be cleaner to create s3Path from sleeperTable inside this constructor, as sleeperTable is effectively being passed in twice?
gaffer01
approved these changes
Sep 29, 2023
patchwork01
approved these changes
Sep 29, 2023
Base automatically changed from
1351-dynamodb-state-store-for-all-tables
to
main
October 2, 2023 09:09
kr565370
added
pr-base-for-stacking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
PR"
Tests
Documentation
separate issue for that below.
NOTICES file to reflect this.