Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split transaction upload to S3 out of transaction log store #4041

Open
patchwork01 opened this issue Jan 9, 2025 · 0 comments · May be fixed by #4052
Open

Split transaction upload to S3 out of transaction log store #4041

patchwork01 opened this issue Jan 9, 2025 · 0 comments · May be fixed by #4052
Assignees
Milestone

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Jan 9, 2025

Background

Split from:

Required for:

Description

We'd like to refactor the code that uploads a transaction to S3 to give us the option to do that before we pass the transaction to the transaction log store.

This is so that we can upload a transaction to S3 before we pass it to the state store committer lambda.

Analysis

We'll need to be able to say that the transaction has already been written to S3, and we could move the responsibility for uploading the transaction out of the log store entirely.

Currently the transaction gets uploaded to S3 in DynamoDBTransactionLogStore.setBodyDirectlyOrInS3IfTooBig. We can make a separate class to do that, and we could call that before we call the TransactionLogStore to add the transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants