Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State store method to add a transaction from S3 #3899

Open
rtjd6554 opened this issue Dec 10, 2024 · 0 comments
Open

State store method to add a transaction from S3 #3899

rtjd6554 opened this issue Dec 10, 2024 · 0 comments

Comments

@rtjd6554
Copy link
Collaborator

rtjd6554 commented Dec 10, 2024

Background

Split from:

Related to:

Description

We'll need to add some method on the state store to be able to add a transaction that's held in S3. This method could take the metadata that we expect to be in the SQS message and the transaction log, and also a pointer to the transaction body in S3. The state store can then read the body from S3 and apply it to the log.

Analysis

We will want the TransactionType and a pointer to the S3 data bucket for the transaction. Will be able to deserialise the transaction with the TransactionSerDe, which takes the TransactionType mentioned previous.

A new interface can be used to build the transaction object, this will be from extracting the body from S3. From this a new method will be created, similar in nature to those within TransactionLogFileReferenceStore, but instead of the transaction being created anew, it is populated from the aforementioned transaction from S3.

We'll also need to adjust the TransactionLogStore, as currently storing and loading transactions to/from S3 happens inside the implementation of that class. We can move that logic out, and operate against a separate interface to store the body of the transaction in S3. The TransactionLogEntry would also need to be adjusted to know whether the transaction body is held in S3.

@rtjd6554 rtjd6554 added the enhancement New feature or request label Dec 10, 2024
@rtjd6554 rtjd6554 added this to the 0.28.0 milestone Dec 10, 2024
@rtjd6554 rtjd6554 changed the title Include method signature to add a transaction from S3 Include state store method signature to add a transaction from S3 Dec 10, 2024
@patchwork01 patchwork01 added statestore-module and removed enhancement New feature or request labels Dec 10, 2024
@patchwork01 patchwork01 changed the title Include state store method signature to add a transaction from S3 State store method to add a transaction from S3 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants