Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async_trait in object store logging #4025

Closed
patchwork01 opened this issue Jan 7, 2025 · 0 comments · Fixed by #4026
Closed

Use async_trait in object store logging #4025

patchwork01 opened this issue Jan 7, 2025 · 0 comments · Fixed by #4026
Assignees
@patchwork01
Milestone
0.28.0

Comments

@patchwork01
Copy link
Collaborator

Background

Follows up from:

Description

When implementing the ObjectStore trait, we could avoid extra code if we use the async_trait macro. This may be applicable to our implementation that wraps an object store and adds logging.

Analysis

This is in store.rs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patchwork01 patchwork01

Labels
None yet
Projects
None yet
Milestone
0.28.0
Development

Successfully merging a pull request may close this issue.

Issue 4025 - Use async_trait for LoggingObjectStore gchq/sleeper
1 participant
@patchwork01