Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting for Rust code #3199

Closed
patchwork01 opened this issue Sep 5, 2024 · 0 comments · Fixed by #3285
Closed

Linting for Rust code #3199

patchwork01 opened this issue Sep 5, 2024 · 0 comments · Fixed by #3285
Assignees
Milestone

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Sep 5, 2024

Background

Split from:

Description

We'd like to add linting for the new Rust code, similar to what we have for Java with Checkstyle.

Analysis

Rust has some linting built in, with compiler warnings:

https://doc.rust-lang.org/rustc/lints/index.html

We could add an option to fail the build if there are any compiler warnings, and turn that on in GitHub Actions:

https://users.rust-lang.org/t/how-to-fail-a-build-with-warnings/2687/5

There's also Clippy:

https://github.com/rust-lang/rust-clippy

Clippy can report on compiler warnings as well, so we don't need both.

@patchwork01 patchwork01 added this to the 0.25.0 milestone Sep 5, 2024
@patchwork01 patchwork01 changed the title Linter for Rust code Linting for Rust code Sep 5, 2024
@patchwork01 patchwork01 self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant