Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for Rust compaction from Java #2850

Closed
patchwork01 opened this issue Jul 9, 2024 · 0 comments · Fixed by #3168
Closed

Test coverage for Rust compaction from Java #2850

patchwork01 opened this issue Jul 9, 2024 · 0 comments · Fixed by #3168
Assignees
Milestone

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Jul 9, 2024

Background

Split from:

Depends on:

Description

We'd like to add any missing test coverage for the linked issue, and ensure it's tested in the GitHub Actions workflows.

Analysis

The compaction-rust module currently has no tests.

Most of the Rust code is untested, except for quantiles.rs in the rust_sketch module.

A number of test files in the Java compaction-runner module are named to refer to a class that has been renamed, i.e. CompactSortedFiles has been renamed to CompactionRunner.

The test helper for instantiating CompactSortedFiles has been changed to create a DefaultSelector object, which could be hidden as an implementation detail for the purposes of tests. These tests can work against CompactionRunner, and the compaction selector could just exist in the test helper.

We could extend the tests against CompactionRunner to also test with Rust. We could add coverage for the logic in DefaultSelector. We could test any usage of the methods on the CompactionRunnerDetails interface, and remove any that are not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant