Skip to content

Commit

Permalink
Remove references to batches from queue properties
Browse files Browse the repository at this point in the history
  • Loading branch information
kr565370 committed Apr 26, 2024
1 parent 5b7f9dc commit f8ef237
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
import static sleeper.configuration.properties.instance.CommonProperty.TABLE_BATCHING_LAMBDAS_MEMORY_IN_MB;
import static sleeper.configuration.properties.instance.CommonProperty.TABLE_BATCHING_LAMBDAS_TIMEOUT_IN_SECONDS;
import static sleeper.configuration.properties.instance.CommonProperty.TRANSACTION_LOG_SNAPSHOT_CREATION_BATCH_SIZE;
import static sleeper.configuration.properties.instance.CommonProperty.TRANSACTION_LOG_SNAPSHOT_CREATION_LAMBDA_PERIOD_IN_MINUTES;;
import static sleeper.configuration.properties.instance.CommonProperty.TRANSACTION_LOG_SNAPSHOT_CREATION_LAMBDA_PERIOD_IN_SECONDS;;

public class TransactionLogSnapshotCreationStack extends NestedStack {

Expand Down Expand Up @@ -92,7 +92,7 @@ public TransactionLogSnapshotCreationStack(
Rule rule = Rule.Builder.create(this, "TransactionLogSnapshotCreationSchedule")
.ruleName(SleeperScheduleRule.TRANSACTION_LOG_SNAPSHOT_CREATION.buildRuleName(instanceProperties))
.schedule(Schedule.rate(Duration.minutes(
instanceProperties.getLong(TRANSACTION_LOG_SNAPSHOT_CREATION_LAMBDA_PERIOD_IN_MINUTES))))
instanceProperties.getLong(TRANSACTION_LOG_SNAPSHOT_CREATION_LAMBDA_PERIOD_IN_SECONDS))))
.targets(List.of(new LambdaFunction(snapshotCreationTrigger)))
.enabled(!shouldDeployPaused(this))
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,19 +103,19 @@ public interface CdkDefinedInstanceProperty extends InstanceProperty {
.propertyGroup(InstancePropertyGroup.COMMON)
.build();
CdkDefinedInstanceProperty TRANSACTION_LOG_SNAPSHOT_CREATION_QUEUE_URL = Index.propertyBuilder("sleeper.metadata.transactionlog.snapshots.creation.queue.url")
.description("URL of the queue for sending batches of transaction log snapshot creation requests.")
.description("URL of the queue for transaction log snapshot creation requests.")
.propertyGroup(InstancePropertyGroup.COMMON)
.build();
CdkDefinedInstanceProperty TRANSACTION_LOG_SNAPSHOT_CREATION_QUEUE_ARN = Index.propertyBuilder("sleeper.metadata.transactionlog.snapshots.creation.queue.arn")
.description("The ARN of the queue for sending batches of transaction log snapshot creation requests.")
.description("The ARN of the queue for transaction log snapshot creation requests.")
.propertyGroup(InstancePropertyGroup.COMMON)
.build();
CdkDefinedInstanceProperty TRANSACTION_LOG_SNAPSHOT_CREATION_DLQ_URL = Index.propertyBuilder("sleeper.metadata.transactionlog.snapshots.creation.dlq.url")
.description("The URL of the dead letter queue for sending batches of transaction log snapshot creation requests.")
.description("The URL of the dead letter queue for transaction log snapshot creation requests.")
.propertyGroup(InstancePropertyGroup.COMMON)
.build();
CdkDefinedInstanceProperty TRANSACTION_LOG_SNAPSHOT_CREATION_DLQ_ARN = Index.propertyBuilder("sleeper.metadata.transactionlog.snapshots.creation.dlq.arn")
.description("The ARN of the dead letter queue for sending batches of transaction log snapshot creation requests.")
.description("The ARN of the dead letter queue for transaction log snapshot creation requests.")
.propertyGroup(InstancePropertyGroup.COMMON)
.build();
CdkDefinedInstanceProperty TRANSACTION_LOG_SNAPSHOT_CREATION_RULE = Index.propertyBuilder("sleeper.metadata.transactionlog.snapshots.creation.rule")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public interface CommonProperty {
.validationPredicate(Utils::isPositiveIntegerLtEq10)
.propertyGroup(InstancePropertyGroup.COMMON)
.build();
UserDefinedInstanceProperty TRANSACTION_LOG_SNAPSHOT_CREATION_LAMBDA_PERIOD_IN_MINUTES = Index.propertyBuilder("sleeper.metadata.transactionlog.snapshot.creation.lambda.period.minutes")
UserDefinedInstanceProperty TRANSACTION_LOG_SNAPSHOT_CREATION_LAMBDA_PERIOD_IN_SECONDS = Index.propertyBuilder("sleeper.metadata.transactionlog.snapshot.creation.lambda.period.seconds")
.description("The frequency in minutes with which the transaction log snapshot creation lambda is run.")
.defaultValue("5")
.validationPredicate(Utils::isPositiveInteger)
Expand Down

0 comments on commit f8ef237

Please sign in to comment.