Log each partition individually in PartitionsFromSplitPointsTest

gchq · Mar 13, 2024 · 4a7e99a · 4a7e99a
1 parent 5a5c837
commit 4a7e99a
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/java/core/src/main/java/sleeper/core/partition/PartitionsFromSplitPoints.java b/java/core/src/main/java/sleeper/core/partition/PartitionsFromSplitPoints.java
@@ -32,7 +32,6 @@
 import sleeper.core.schema.type.Type;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 import java.util.UUID;
@@ -109,18 +108,18 @@ private List<Partition.Builder> addLayer(List<Partition.Builder> partitionsInLay
                 ranges.add(rangeForDim0);
                 Region region = new Region(ranges);
                 String id = UUID.randomUUID().toString();
+                List<String> childPartitionIds = List.of(leftPartition.getId(), rightPartition.getId());
                 Partition.Builder parent = Partition.builder()
                         .id(id)
                         .parentPartitionId(null)
-                        .childPartitionIds(Arrays.asList(leftPartition.getId(), rightPartition.getId()))
+                        .childPartitionIds(childPartitionIds)
                         .leafPartition(false)
                         .dimension(0)
                         .rowKeyTypes(schema.getRowKeyTypes())
                         .region(region);
-
                 leftPartition.parentPartitionId(id);
                 rightPartition.parentPartitionId(id);
-
+                LOGGER.debug("Created parent partition " + id + " joining partitions " + childPartitionIds);
                 parents.add(parent);
             }
         }
@@ -133,7 +132,6 @@ private List<Partition.Builder> addLayer(List<Partition.Builder> partitionsInLay
         }
 
         LOGGER.info("Created layer of {} partitions from previous layer of {} partitions", parents.size(), partitionsInLayer.size());
-        LOGGER.debug("New partitions are {}", parents);
 
         return parents;
     }
@@ -142,18 +140,19 @@ private List<Partition.Builder> createLeafPartitions() {
         List<Region> leafRegions = leafRegionsFromSplitPoints(schema, splitPoints);
         List<Partition.Builder> leafPartitions = new ArrayList<>();
         for (Region region : leafRegions) {
+            String id = UUID.randomUUID().toString();
             Partition.Builder partition = Partition.builder()
                     .rowKeyTypes(schema.getRowKeyTypes())
                     .region(region)
-                    .id(UUID.randomUUID().toString())
+                    .id(id)
                     .leafPartition(true)
                     .parentPartitionId(null)
                     .childPartitionIds(new ArrayList<>())
                     .dimension(-1);
+            LOGGER.debug("Created leaf partition " + id + " for region " + region);
             leafPartitions.add(partition);
         }
         LOGGER.info("Created {} leaf partitions from {} split points", leafPartitions.size(), splitPoints.size());
-        LOGGER.debug("Partitions are {}", leafPartitions);
         return leafPartitions;
     }