Skip to content

Commit

Permalink
Update default valuesbased on review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rtjd6554 committed Nov 18, 2024
1 parent c7709f3 commit 06b32ea
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions example/full/instance.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1076,12 +1076,12 @@ sleeper.default.table.compaction.job.send.batch.size=10
# It's also necessary to ensure file assignment will be done before the next invocation of compaction
# job creation, otherwise invalid jobs will be created for the same input files. The rate of these
# invocations is set in `sleeper.compaction.job.creation.period.minutes`.
sleeper.default.table.compaction.job.send.timeout.seconds=40
sleeper.default.table.compaction.job.send.timeout.seconds=90

# The amount of time in seconds to wait between attempts to send a batch of compaction jobs. The batch
# will be sent if all input files have been successfully assigned to the jobs, otherwise the batch
# will be retried after a delay.
sleeper.default.table.compaction.job.send.retry.delay.seconds=10
sleeper.default.table.compaction.job.send.retry.delay.seconds=30

# Used by the SizeRatioCompactionStrategy to decide if a group of files should be compacted.
# If the file sizes are s_1, ..., s_n then the files are compacted if s_1 + ... + s_{n-1} >= ratio *
Expand Down
4 changes: 2 additions & 2 deletions example/full/table.properties
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,12 @@ sleeper.table.compaction.job.send.batch.size=10
# It's also necessary to ensure file assignment will be done before the next invocation of compaction
# job creation, otherwise invalid jobs will be created for the same input files. The rate of these
# invocations is set in `sleeper.compaction.job.creation.period.minutes`.
sleeper.table.compaction.job.send.timeout.seconds=40
sleeper.table.compaction.job.send.timeout.seconds=90

# The amount of time in seconds to wait between attempts to send a batch of compaction jobs. The batch
# will be sent if all input files have been successfully assigned to the jobs, otherwise the batch
# will be retried after a delay.
sleeper.table.compaction.job.send.retry.delay.seconds=10
sleeper.table.compaction.job.send.retry.delay.seconds=30

# If true, compaction job ID assignment commit requests will be sent to the state store committer
# lambda to be performed asynchronously. If false, compaction job ID assignments will be committed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,14 @@ public interface CompactionProperty {
"It's also necessary to ensure file assignment will be done before the next invocation of " +
"compaction job creation, otherwise invalid jobs will be created for the same input files. " +
"The rate of these invocations is set in `sleeper.compaction.job.creation.period.minutes`.")
.defaultValue("40")
.defaultValue("90")
.validationPredicate(SleeperPropertyValueUtils::isPositiveInteger)
.propertyGroup(InstancePropertyGroup.COMPACTION).build();
UserDefinedInstanceProperty DEFAULT_COMPACTION_JOB_SEND_RETRY_DELAY_SECS = Index.propertyBuilder("sleeper.default.table.compaction.job.send.retry.delay.seconds")
.description("The amount of time in seconds to wait between attempts to send a batch of compaction jobs. " +
"The batch will be sent if all input files have been successfully assigned to the jobs, otherwise " +
"the batch will be retried after a delay.")
.defaultValue("10")
.defaultValue("30")
.validationPredicate(SleeperPropertyValueUtils::isPositiveInteger)
.propertyGroup(InstancePropertyGroup.COMPACTION).build();
UserDefinedInstanceProperty DEFAULT_SIZERATIO_COMPACTION_STRATEGY_RATIO = Index.propertyBuilder("sleeper.default.table.compaction.strategy.sizeratio.ratio")
Expand Down
4 changes: 2 additions & 2 deletions scripts/templates/instanceproperties.template
Original file line number Diff line number Diff line change
Expand Up @@ -1100,12 +1100,12 @@ sleeper.default.table.compaction.job.send.batch.size=10
# It's also necessary to ensure file assignment will be done before the next invocation of compaction
# job creation, otherwise invalid jobs will be created for the same input files. The rate of these
# invocations is set in `sleeper.compaction.job.creation.period.minutes`.
sleeper.default.table.compaction.job.send.timeout.seconds=40
sleeper.default.table.compaction.job.send.timeout.seconds=90

# The amount of time in seconds to wait between attempts to send a batch of compaction jobs. The batch
# will be sent if all input files have been successfully assigned to the jobs, otherwise the batch
# will be retried after a delay.
sleeper.default.table.compaction.job.send.retry.delay.seconds=10
sleeper.default.table.compaction.job.send.retry.delay.seconds=30

# Used by the SizeRatioCompactionStrategy to decide if a group of files should be compacted.
# If the file sizes are s_1, ..., s_n then the files are compacted if s_1 + ... + s_{n-1} >= ratio *
Expand Down

0 comments on commit 06b32ea

Please sign in to comment.