Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-415: In-depth aggregation guide #420

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Gh-415: In-depth aggregation guide #420

merged 10 commits into from
Oct 18, 2023

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Oct 11, 2023 •
edited by github-actions bot
Loading

Added pages covering aggregation in a bit more detail, there exists a decent about on query-time aggregation already under the user guide but supplemented that with full examples covering ingest aggregation.

Related Issue

@tb06904 tb06904 linked an issue Oct 11, 2023 that may be closed by this pull request
Add In-depth Aggregation Guide #415
Closed
GCHQDeveloper314
GCHQDeveloper314 reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only very minor comments. The content all looks correct to me and a useful introduction to aggregation.

docs/user-guide/gaffer-basics/what-is-aggregation.md Show resolved Hide resolved
docs/user-guide/gaffer-basics/what-is-aggregation.md Outdated Show resolved Hide resolved
docs/user-guide/gaffer-basics/what-is-aggregation.md Outdated Show resolved Hide resolved
docs/administration-guide/aggregation/overview.md Outdated Show resolved Hide resolved
docs/administration-guide/aggregation/overview.md Outdated Show resolved Hide resolved
docs/administration-guide/aggregation/ingest-example.md Outdated Show resolved Hide resolved
@GCHQDeveloper314 GCHQDeveloper314 changed the title Gh-415 in depth aggregation guide Gh-415: In-depth aggregation guide Oct 13, 2023
@tb06904 tb06904 requested a review from cn337131 October 17, 2023 11:08
@tb06904 tb06904 requested a review from t92549 October 17, 2023 11:08
@t92549 t92549 merged commit a35f2d7 into v2docs Oct 18, 2023
2 checks passed
@t92549 t92549 deleted the gh-415-in-depth-aggregation-guide branch October 18, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t92549 t92549 t92549 approved these changes

@GCHQDeveloper314 GCHQDeveloper314 GCHQDeveloper314 approved these changes

@cn337131 cn337131 cn337131 approved these changes

@l46978 l46978 Awaiting requested review from l46978

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add In-depth Aggregation Guide
4 participants
@tb06904 @t92549 @GCHQDeveloper314 @cn337131