Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-192: Federated Store Guide #416

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Gh-192: Federated Store Guide #416

merged 8 commits into from
Oct 18, 2023

Conversation

GCHQDeveloper314
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 commented Oct 10, 2023 •
edited by github-actions bot
Loading

This is no longer called a walkthrough. Some content is now part of the separate Federated Operation guide.

Related Issue

@GCHQDeveloper314
Import Federated Store Walkthough from old docs and update
94b833f 
This is no longer called a walkthrough. Some content is now part of the separate Federated Operation guide.
@GCHQDeveloper314
Copy link
Member Author

I had been wondering if the federation specific operations should instead be part of the operation guide section and not this page?

@l46978
Copy link
Member

l46978 commented Oct 11, 2023

I had been wondering if the federation specific operations should instead be part of the operation guide section and not this page?

I agree with this.

@GCHQDeveloper314 GCHQDeveloper314 mentioned this pull request Oct 12, 2023
Open
@GCHQDeveloper314
Copy link
Member Author

The operation specific docs added in this PR would be best placed in the reference guide. There's an existing issue to add docs for all Federated Store operation to the reference guide. I've added a comment to that issue explaining that some of the required information can be migrated from this guide.

t92549
t92549 reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@t92549 t92549 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update! I think a new issue should be made to create a Federation Operations page under the Operations docs. Edit: This is already an issue (#187)

docs/administration-guide/gaffer-stores/federated-store.md Outdated Show resolved Hide resolved
docs/administration-guide/gaffer-stores/federated-store.md Outdated Show resolved Hide resolved
docs/administration-guide/gaffer-stores/federated-store.md Show resolved Hide resolved
docs/administration-guide/gaffer-stores/federated-store.md Outdated Show resolved Hide resolved
docs/administration-guide/gaffer-stores/federated-store.md Outdated Show resolved Hide resolved
@GCHQDeveloper314 GCHQDeveloper314 mentioned this pull request Oct 16, 2023
Closed
@t92549 t92549 requested a review from tb06904 October 18, 2023 12:43
@t92549 t92549 merged commit 2adced8 into v2docs Oct 18, 2023
1 check passed
@t92549 t92549 deleted the gh-192-federated-store-guide branch October 18, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l46978 l46978 l46978 left review comments

@t92549 t92549 t92549 approved these changes

@cn337131 cn337131 cn337131 approved these changes

@tb06904 tb06904 tb06904 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update FederatedStore Walkthrough
5 participants
@GCHQDeveloper314 @l46978 @t92549 @tb06904 @cn337131