Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-353: Document CommonConstants removal #372

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Gh-353: Document CommonConstants removal #372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/gaffer2.0/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,12 @@ Now set in `serialiser`:
- This class has been removed.
- Use the equivalent `TestTypes` class in the store module `uk.gov.gchq.gaffer.store.TestTypes` instead.

### [`commonutil.CommonConstants`](https://github.com/gchq/Gaffer/blob/gaffer2-1.21.1/core/common-util/src/main/java/uk/gov/gchq/gaffer/commonutil/CommonConstants.java)
- This class has been removed as it was redundant.
- For the `UTF-8` constant use `StandardCharsets.UTF_8.name()` from built in Java libraries.
- The above also applies to the `ISO_8859_1` constant from this class.
- This also allows for more robust error handing, [this commit is an example of a change implementing this](https://github.com/gchq/Gaffer/commit/3999890f3aebadbc5384695123af89a4d9053333#diff-faa371afa5e6d548ff73af92f1f148870424e7858e3fef43b3d25bc5b740c013).

### [`data.elementdefinition.view.NamedViewDetail`](https://github.com/gchq/Gaffer/blob/gaffer2-1.21.1/core/data/src/main/java/uk/gov/gchq/gaffer/data/elementdefinition/view/NamedViewDetail.java)
- The method `hasWriteAccess(String userId, Set<String> opAuths, String adminAuth)` has been removed.
- Use `hasWriteAccess(User user, String adminAuth)` instead.
Expand Down
Loading