Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated items slated for removal in v0.4.0 #958

Merged
merged 6 commits into from
Feb 10, 2025
Merged

Remove deprecated items slated for removal in v0.4.0 #958

merged 6 commits into from
Feb 10, 2025

Conversation

rg936672
Copy link
Contributor

@rg936672 rg936672 commented Feb 7, 2025

PR Type

  • Refactoring (no functional changes)

Description

Closes #785. Also adds expected removal versions to the deprecated aliases introduced in #943.

How Has This Been Tested?

All items slated for removal have been removed.

Does this PR introduce a breaking change?

Yes, but the changes have been signposted since v0.3.0.

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

@rg936672 rg936672 marked this pull request as ready for review February 7, 2025 14:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Performance review

Commit c12aa66 - Merge cafa90f into 94a1a2d

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Performance review

Commit 8b32fbe - Merge 1f83681 into 94a1a2d

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 0f9c387 - Merge 04ce343 into 12c0b91

No significant changes to performance.

@tp832944 tp832944 self-requested a review February 10, 2025 09:27
tp832944
tp832944 requested changes Feb 10, 2025
View reviewed changes
coreax/coreset.py Outdated Show resolved Hide resolved
coreax/coreset.py Outdated Show resolved Hide resolved
coreax/coreset.py Outdated Show resolved Hide resolved
coreax/coreset.py Outdated Show resolved Hide resolved
coreax/coreset.py Outdated Show resolved Hide resolved
coreax/coreset.py Outdated Show resolved Hide resolved
coreax/coreset.py Outdated Show resolved Hide resolved
coreax/coreset.py Outdated Show resolved Hide resolved
coreax/coreset.py Outdated Show resolved Hide resolved
coreax/coreset.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 476db92 - Merge f52bd09 into 6715f82

No significant changes to performance.

@tp832944 tp832944 merged commit d16bb65 into main Feb 10, 2025
23 checks passed
@tp832944 tp832944 deleted the feature/v0.4.0-deprecation-removals branch February 10, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tp832944 tp832944 tp832944 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for v0.4.0 deprecations
2 participants
@rg936672 @tp832944