:fix: correct plot scaling calculation and leaf parameters #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix scale calculation to use downsampling factor squared - Update leaf count to 16,000
…ndom_weights` in the plots
|
From my local testing, I get |
rg936672
requested changes
Oct 30, 2024
rg936672
requested changes
Nov 5, 2024
There was a problem hiding this comment.
This all looks good; the new scaling is much more visually apparent. As a last change, we should add this fix to CHANGELOG (and you'll want to merge in main first in order to avoid merge conflicts).
While you're making changes, it might also be good to note in the example (in a comment or docstring) that the point scaling is deliberately exaggerated for visual clarity.
rg936672
requested changes
Nov 5, 2024
rg936672
previously approved these changes
Nov 6, 2024
rg936672
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
The algorithm's execution was slow, not because of image size but due to the leafsize being too close to the coreset_size and there was a bug when we set downsampling factor = 8 which has been fixed here:
How Has This Been Tested?
Test A: (Write your answer here.)
Test B: (Write your answer here.)
Test C: (Write your answer here.)
Does this PR introduce a breaking change?
No
Screenshots
(Write your answer here.)
Checklist before requesting a review