Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix: correct plot scaling calculation and leaf parameters #821

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qh681248
Copy link
Contributor

PR Type

  • Bugfix
  • Feature

Description

The algorithm's execution was slow, not because of image size but due to the leafsize being too close to the coreset_size and there was a bug when we set downsampling factor = 8 which has been fixed here:

  • Increase leafsize was from 10,000 to either 16,000, which speeds up the algorithm, even when downsampling = 1.
  • Fix scale calculation to use downsampling factor squared
  • Update leaf count to 16,000

How Has This Been Tested?

Test A: (Write your answer here.)
Test B: (Write your answer here.)
Test C: (Write your answer here.)

Does this PR introduce a breaking change?

No

Screenshots

(Write your answer here.)

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

- Fix scale calculation to use downsampling factor squared
- Update leaf count to 16,000
@qh681248 qh681248 linked an issue Oct 23, 2024 that may be closed by this pull request
Copy link
Contributor

Performance review

Commit 7119d65 - Merge a4cbc80 into bc5acf0

No significant changes to performance.

Copy link
Contributor

Performance review

Commit eded51e - Merge 07dbc36 into bc5acf0

No significant changes to performance.

@gw265981
Copy link
Contributor

From my local testing, I get RecursionError before the fix and it runs after the fix (takes around 200s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trackdown markersize bug on David example when downsampling = 1.
2 participants