:fix: correct plot scaling calculation and leaf parameters #821
+41
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
The algorithm's execution was slow, not because of image size but due to the leafsize being too close to the coreset_size and there was a bug when we set downsampling factor = 8 which has been fixed here:
How Has This Been Tested?
Test A: (Write your answer here.)
Test B: (Write your answer here.)
Test C: (Write your answer here.)
Does this PR introduce a breaking change?
No
Screenshots
(Write your answer here.)
Checklist before requesting a review