Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.3.0 #819

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Release/0.3.0 #819

wants to merge 9 commits into from

Conversation

qh681248
Copy link
Contributor

PR Type

  • Release

Description

This PR introduces version 0.3.0 of Coreax.

How Has This Been Tested?

Test A: Ran all tests on windows.
Test B: Ran all the tests on the GPU.

Does this PR introduce a breaking change?

No

Screenshots

(Write your answer here.)

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@qh681248 qh681248 linked an issue Oct 23, 2024 that may be closed by this pull request
New coreax release v0.3 #766
Open
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit c14cfee - Merge dd9b5d2 into bc5acf0

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit e261073 - Merge 96d37fc into bc5acf0

No significant changes to performance.

rg936672
rg936672 requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@rg936672 rg936672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes. Also - would it be worth linking each changelog item (especially in the Fixes section) to its respective PR/issue, so users can click through and see more details?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 6d3d4c9 - Merge 5448f69 into bc5acf0

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 347c413 - Merge 94f2140 into bc5acf0

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit db30c70 - Merge c404244 into bc5acf0

No significant changes to performance.

rg936672
rg936672 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@rg936672 rg936672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should hold off on merging this until the release is made, though.

.cspell/custom_misc.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rg936672 rg936672 rg936672 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New coreax release v0.3
2 participants
@qh681248 @rg936672