Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to uv #806

Merged
merged 15 commits into from
Oct 18, 2024
Merged

Migrate to uv #806

merged 15 commits into from
Oct 18, 2024

Conversation

rg936672
Copy link
Contributor

PR Type

  • Build related changes
  • CI related changes

Description

Migrate to uv for dependency management. Closes #804.

How Has This Been Tested?

See if all the workflows still pass.

Does this PR introduce a breaking change?

Not to end users!

Screenshots

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit c7fbf67 - Merge e5ec4b6 into 1832579

No significant changes to performance.

@rg936672
Copy link
Contributor Author

I've hidden it as outdated, but #806 (comment) is a very good illustration of just how important having the latest dependencies is for performance - we experience an up-to-10x slowdown with older package versions!

@tp832944 tp832944 self-requested a review October 14, 2024 15:43
tp832944
tp832944 requested changes Oct 14, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit fc55197 - Merge 0c8d50e into 3463539

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 479e9ee - Merge 005bf76 into 3463539

No significant changes to performance.

tp832944
tp832944 requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@tp832944 tp832944 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete requirements.txt. We have checked that nobody internal requires it.

@rg936672 rg936672 requested a review from tp832944 October 18, 2024 12:08
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 75f70e7 - Merge c7c9dcc into fd334fd

No significant changes to performance.

@rg936672 rg936672 merged commit 75a8b41 into main Oct 18, 2024
19 checks passed
@tp832944 tp832944 deleted the feature/uv branch November 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tp832944 tp832944 tp832944 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to uv for dependency management
2 participants
@rg936672 @tp832944