Skip to content

Commit

Permalink
fix: correct sign of periodic kernel expected gradient
Browse files Browse the repository at this point in the history
  • Loading branch information
rg936672 committed Jan 23, 2025
1 parent 8308711 commit 3ff9268
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/unit/test_kernels.py
Original file line number Diff line number Diff line change
Expand Up @@ -1971,7 +1971,7 @@ def problem(self, request, kernel: PeriodicKernel) -> _Problem: # noqa: C901
)
return _Problem(x, y, expected_distances, modified_kernel)

def expected_grad_x(
def expected_grad_y(
self, x: ArrayLike, y: ArrayLike, kernel: PeriodicKernel
) -> np.ndarray:
x = np.atleast_2d(x)
Expand All @@ -1998,10 +1998,10 @@ def expected_grad_x(
)
return expected_gradients

def expected_grad_y(
def expected_grad_x(
self, x: ArrayLike, y: ArrayLike, kernel: PeriodicKernel
) -> np.ndarray:
return -self.expected_grad_x(x, y, kernel)
return -self.expected_grad_y(x, y, kernel)

def expected_divergence_x_grad_y(
self, x: ArrayLike, y: ArrayLike, kernel: PeriodicKernel
Expand Down

0 comments on commit 3ff9268

Please sign in to comment.